This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: testroot.pristine creation falls over copying dynamic linker
- From: Joseph Myers <joseph at codesourcery dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: <carlos at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Wed, 7 Aug 2019 22:22:03 +0000
- Subject: Re: testroot.pristine creation falls over copying dynamic linker
- Ironport-sdr: ypoQF0z6cukwpkZSFyzWWE4sM6rjkQnctwd/Z7mCBrl5ljCTdnvllOJpYCOzmVtZ13wVFV04iC puB6xnE0foX51BhRTFxyR9KR5pwDuGyamUnxkrHtfJRhojz8eiE/Liydn/Ok5vzT/u13U/Od0Z yWJkU67zueYpM48CFzlqOJrEkr+UEedimG97zUdR/rjXDREXnFG6tHEsh09P2AUXDz6J5Irz2w 5xm8NWsOdwMlTf+Cql9WHVBvjFDuOl96iZ1CNDGvAEa16UlIdym8TNcGW0OHM2wdYidQSUT001 xq0=
- Ironport-sdr: an4Q7FSredqwWZ/Zqco0k3Ei09xaP6Z2T3tgXxUkUvhXqFcmrDvRYPtNkgWZf8tVLZfQbrSv5y m5neZUFNpOoQcF2wSC9xO7xinKF3V0NwZLGlZnxw1S2p6gQW0Pui7wv2QOLdnUwF9LN+Ga2AKL 48wont+MtdVn/ba0ZbrJEqaqed8ZFCj7rnCKBFHiAOML8EdbpDrJdDl45YDAJckF1m+8RMFcnL i6a0sdSySZnkr2W3ekHLbRRKfe3Pgre13j6wMhyuKMXnwwUfu9O8cSkF4OWxPv4MxWGsRLiuo4 RGQ=
- References: <xn5zn8r5qe.fsf@greed.delorie.com>
On Wed, 7 Aug 2019, DJ Delorie wrote:
> Joseph Myers <joseph@codesourcery.com> writes:
> > I have now done a MIPS test of this patch in the
> > --enable-hardcoded-path-in-tests case and confirmed it also works in that
> > case as well - of course in that case it copies libraries to paths under
> > <builddir>/testroot.pristine/<builddir> so that execution within the
> > testroot can find the libraries at the hardcoded paths.
>
> Does that work? IIRC I mount builddir into the testroot, so if you
> create files under testroot/builddir from *outside* the testroot,
> they'll get hidden when the container runs.
If they're hidden by identical files, that's fine; the copies may have
been unnecessary in that case, but are harmless. It's simply a
consequence of the LD_TRACE_LOADED_OBJECTS=1 calls, both before and after
the proposed patch, that in the --enable-hardcoded-path-in-tests case the
dynamic linker gets copied to testroot.pristine/builddir because that's
the hardcoded path. (In fact some files get copied to
testroot.pristine/builddir even in the absence of
--enable-hardcoded-path-in-tests and without the patch.)
--
Joseph S. Myers
joseph@codesourcery.com