This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] login: Assume that _HAVE_UT_* constants are defined

From: Florian Weimer <fweimer at redhat dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Mon, 12 Aug 2019 22:10:50 +0200
Subject: Re: [PATCH] login: Assume that _HAVE_UT_* constants are defined
References: <87imr2vhb9.fsf@oldenburg2.str.redhat.com> <9ff8cfea-c98e-3f79-dd7f-919045224c67@linaro.org>

* Adhemerval Zanella:

>> +	  || __utmp_equal (&last_entry, data)))
>
> Shouldn't we check for > 0 instead of a implicit check?

The style guidelines do not have a strong preference in case of true
flags.

We could change __utmp_equal to return bool, maybe in a subsequent
cleanup.

Thanks,
Florian

References:
- [PATCH] login: Assume that _HAVE_UT_* constants are defined
  - From: Florian Weimer
- Re: [PATCH] login: Assume that _HAVE_UT_* constants are defined
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]