This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch v1] nptl: smarter not-parallel-ing
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: DJ Delorie <dj at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 14 Aug 2019 07:54:41 +0200
- Subject: Re: [patch v1] nptl: smarter not-parallel-ing
- References: <xnef1onvw1.fsf@greed.delorie.com>
* DJ Delorie:
> Florian Weimer <fw@deneb.enyo.de> writes:
>>> Here $^ expands to "" because $(objpfx)tst-cleanup0.out is *also* listed
>>> in :|
>>
>> That's really odd. Why would $(objpfx)tst-cleanup0.out be listed for
>> the *same* rule? Doesn't this mean that $(ALLTESTS) contains duplicates?
>
> The sequencing for the :| rules happens to result in this one:
>
> $(objpfx)tst-cleanup0-cmp.out :| $(objpfx)tst-cleanup0.out
>
> The problem is that make filters out :| dependencies from $^ even if
> they're regular dependencies also.
Hmm. I don't see this with GNU make 4.2.1. I wonder if | targets are
filtered in your version of make, they are gone completely and do not
factor into the decision when a target has to be remade. That would
make nptl/Makefile slightly buggy.