This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 3/4] Refactor sigcontextinfo.h



On 20/08/2019 09:33, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> On 20/08/2019 08:51, Florian Weimer wrote:
>>> * Adhemerval Zanella:
>>>
>>>> diff --git a/sysdeps/posix/profil.c b/sysdeps/posix/profil.c
>>>> index 838c36d060..4b8fd9caf1 100644
>>>> --- a/sysdeps/posix/profil.c
>>>> +++ b/sysdeps/posix/profil.c
>>>
>>>> @@ -71,6 +72,10 @@ __profil (u_short *sample_buffer, size_t size, size_t offset, u_int scale)
>>>>  # define oact_ptr &oact
>>>>  # define otimer_ptr &otimer
>>>>  
>>>> +# ifdef SA_SIGINFO
>>>> +  oact.sa_flags |= SA_SIGINFO;
>>>> +# endif
>>>> +
>>>
>>> I do not understand the purpose of this change.
>>
>> This code is shared with Hurd and it does not support SA_SIGINFO
>> handler afaiu.
> 
> Hurd indeed does not SA_SIGINFO.  I do not understand the update of
> oact.
> 

Right, it indeed wrong. I removed this locally.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]