This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Fix typos and field name in comments

Gustavo Romero <gromero@linux.vnet.ibm.com> writes:

>>>   /* Number of general registers.  */
>>> -# define __NGREG	48	/* includes r0-r31, nip, msr, lr, etc.   */
>>> +# define __NGREG	48	/* includes r0-r31, nip, msr, lr, etc.  */
>> 
>> I'm afraid this modification should not be here.
>> Or am I missing a fix here?
>
> I see 3 spaces in the original version. Since in that file I found comments
> ending with 1 or 2 spaces before "*/" I thought it would be good to remove
> at least 1 space from these 3 spaces. But we can discard that nit if you deem it
> not right, sure.

You're correct.
You fixed a typo, I created a thinko.  ;-)

Pushed as c8c8160ceebb6.

Thanks,

-- 
Tulio Magno
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]