This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] [MIPS] Raise highest supported EI_ABIVERSION value [BZ #24916]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mihailo Stojanovic <mihailo dot stojanovic at rt-rk dot com>
- Cc: <libc-alpha at sourceware dot org>, "Maciej W . Rozycki" <macro at linux-mips dot org>, Carlos O'Donell <carlos at redhat dot com>, Dragan Mladjenovic <dragan dot mladjenovic at rt-rk dot com>
- Date: Fri, 23 Aug 2019 16:48:18 +0000
- Subject: Re: [PATCH v4] [MIPS] Raise highest supported EI_ABIVERSION value [BZ #24916]
- Ironport-sdr: v+R7UM7BMfg1KxsY7LAhstoUMmg7jzcrIF2daI+Yvw2uGr1XpFgHmPSuEKlMA4N4UsdAdE7F7r gMtzTAesMYzT1laAVItjGeQx6fEsNxaGvegLBcsCtkR2+zgRXgFv4hYkfUf85vVpXx/trl59yw sQqNcNqL+XsMpbZTKHcPWN7uuo02mH0wt9HO2BMjcKNg7IOVwisDkmRlW/K5ZQ2K4K+d+TtLJS UJyXqUfzONUYtv75w+qiDnDxD5mRvronGWOpO5TH9DuBRAa0u5au1O09R35gttV/0pZTXoDHiz YMc=
- Ironport-sdr: UQ6UCIdrfQU9IG7puZ+xRmDx4f+LVhk4ZRgNSdWPqGuSL+BWLfcy1UyPvjf8EAh7/HE2aFzYXI 2LusTO+2FIEmfa6ti3LVC8InqI0fCGe1ioW4Z/6p7dj11u7TVRCA+7drY4q2mB4xkHHfzec3jL hoPqO9CFLsDqd/jEs0amCoPDqEP+H7itTIPZo2v1sCY+4QD8far5KHp8zqrQ6VEQ251T4exwJY nfZQmWFnH9LtL7cscdj1UvKr7+oMurEcMrirbnHqgNTTnbihCpcsky6fF7NKldOozdlwTx2Kl7 tBw=
- References: <1566564137-26801-1-git-send-email-mihailo.stojanovic@rt-rk.com>
On Fri, 23 Aug 2019, Mihailo Stojanovic wrote:
> This bumps the highest valid EI_ABIVERSION value to ABSOLUTE ABI.
>
> New testcase loads the symbol from the GOT with the "lb" instruction
> so that the EI_ABIVERSION header field of the shared object is set
> to ABSOLUTE (it doesn't actually check the value of the symbol), and
> makes sure that the main executable is executed without "ABI version
> invalid" error.
>
> Tested for all three ABIs (o32, n32, n64) using both static linker which
> handles undefined weak symbols correctly [1] (and sets the EI_ABIVERSION
> of the test module) and the one that doesn't (EI_ABIVERSION left as 0).
>
> [1] https://sourceware.org/ml/binutils/2018-07/msg00268.html
Thanks, I've committed this patch.
--
Joseph S. Myers
joseph@codesourcery.com