This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Speedup nptl/tst-mutex9 and nptl/tst-mutexpi9.
- From: Stefan Liebler <stli at linux dot ibm dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 12 Sep 2019 14:15:58 +0200
- Subject: [PATCH] Speedup nptl/tst-mutex9 and nptl/tst-mutexpi9.
Hi,
each test runs for 6s. do_test_clock is called three times where it
sleeps for two seconds and is then checking if the child process
was killed by SIGALRM. The child process tries to lock a mutex
which times out after 0.5s and is setting up alarm(1) before it blocks
due to pthread_mutex_lock.
This patch removes the sleep(2) and reduces the timeout for the first
pthread_mutex_[timed|clock]lock call.
As the nptl tests run in sequence, this patch saves roughly 6s of
runtime for "make check".
Bye,
Stefan
ChangeLog:
* nptl/tst-mutex9.c (do_test_clock): Remove sleep and
reduce timeout.
commit b31fb5820fb30c933b5ef60a1bd3cc8cff8cf17d
Author: Stefan Liebler <stli@linux.ibm.com>
Date: Wed Sep 11 13:49:37 2019 +0200
Speedup nptl/tst-mutex9 and nptl/tst-mutexpi9.
Each test runs for 6s. do_test_clock is called three times where it
sleeps for two seconds and is then checking if the child process
was killed by SIGALRM. The child process tries to lock a mutex
which times out after 0.5s and is setting up alarm(1) before it blocks
due to pthread_mutex_lock.
This patch removes the sleep(2) and reduces the timeout for the first
pthread_mutex_[timed|clock]lock call.
As the nptl tests run in sequence, this patch saves roughly 6s of
runtime for "make check".
ChangeLog:
* nptl/tst-mutex9.c (do_test_clock): Remove sleep and
reduce timeout.
diff --git a/nptl/tst-mutex9.c b/nptl/tst-mutex9.c
index d7adcd5061..f776d21533 100644
--- a/nptl/tst-mutex9.c
+++ b/nptl/tst-mutex9.c
@@ -102,7 +102,7 @@ do_test_clock (clockid_t clockid)
FAIL_EXIT1 ("child: mutex_unlock succeeded");
const struct timespec ts = timespec_add (xclock_now (clockid_for_get),
- make_timespec (0, 500000000));
+ make_timespec (0, 100000000));
if (clockid == CLOCK_USE_TIMEDLOCK)
TEST_COMPARE (pthread_mutex_timedlock (m, &ts), ETIMEDOUT);
@@ -118,8 +118,6 @@ do_test_clock (clockid_t clockid)
exit (0);
}
- sleep (2);
-
int status;
if (TEMP_FAILURE_RETRY (waitpid (pid, &status, 0)) != pid)
FAIL_EXIT1 ("waitpid failed");