This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] inet/net-internal.h: Fix uninitalised clntudp_call() variable
- From: "Maciej W. Rozycki" <macro at wdc dot com>
- To: Alistair Francis <alistair23 at gmail dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Jeff Law <law at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Zack Weinberg <zackw at panix dot com>
- Date: Tue, 24 Sep 2019 22:00:15 +0100 (BST)
- Subject: Re: [PATCH] inet/net-internal.h: Fix uninitalised clntudp_call() variable
- Ironport-sdr: ll7F5h3te9yjX4fFx/iNywkF1BBUsL/LyCEU44igQ+t3epsZI2qq9LYOsmzIRpCFJYh1E9gxUP bBSy2Rs45+JZnf28Mnakewdc3QcDWhY0udcweDzaFmaoKkaHfYRDsIjF22N+4n1P/bfxrgnQTm Cp+FTng5BUgicAnw1G/0G3hB3MN9jSNiII+VNt1Tq9BRZznkOO+YlUaPMiFuo/k05RoWuvkXol W5i/tHXPZ/Jr0vHWq4S8Xlbx9utiXFQdHyckmUGrBXPzTIyTLmGSWpEfqKVUMyeUEgBUxvACfV 5m4=
- Ironport-sdr: F5/pOoKKDb3Zn8cTPoNPb1Zt3jxg61BT8D6Vf9qHak8ZNzjn5dYZTWYd7Rci+Yh5hjOCKsRfUN GXSEAO33tAdFaVyyd13+gz/z7sxTIYvjhiP36kuxGa9yq4jd7hfhJDfpJamNDad/11uAht5+x+ s7SHAA5gQFhjUAqpN0ESo/5u4hd+fwjIifQq6ubfB1C6yfTvuU3och6AutaK8PJM/1GKBQW/ld 1Tcv9xMMRB2SYjHqwwuvdqVEaTeAZhn6A39IhU+g2cRMUZzLbroU+wOV6GXrFWg2QXEsdHPdRU OVcEHJA9AFdduLtMNhECHKDb
- Ironport-sdr: 4+0yFkEW2SXirfQXhJO4P+Z48XLUqgUMB9Vp9/mSmoJluHyGY1eQ9QDZWZwlv+wFhFsdMcZcs0 IoJ9n3aW6HrvC0FDYxyLkD1B+kOQ1hqUwq3oUOyVkLhZbefJpnqXaWRtJJ3WMnoUzAueme4uJb 5PR7+hyX1WH4Zi9thQeRKa/CtdL5M0FKEztbru2k00zBgWD+tYBRcKi1BT81ym3O1ewyGJ0oOD fIIFjPv8klnyK7cW5wwMVXELGrDJbyAIedkIAURt2yRMRClh8HVy6F2ARF0m7gDSIKVMfPAjlP 1mE=
- References: <20190916221536.18500-1-alistair.francis@wdc.com> <83b0d556-ef9d-adbf-85ac-d4ef8857f9b9@redhat.com> <CAKmqyKMCh3rxBnrXi2a7if4ZPzsNZMO+aN1Dc0BJaONuVqQqQw@mail.gmail.com>
- Wdcironportexception: Internal
On Tue, 24 Sep 2019, Alistair Francis wrote:
> > This looks good to me. If you're seeing this using the released 8.3 or 9.2
> > then others will see it too. You also reference the compiler version that
> > is the latest with the problem e.g. 9. I don't think we should fix this
> > by zeroing out the entire field since this looks like an optimization
> > or compiler related issue.
> >
> > OK for master.
>
> Thanks!
>
> I don't have commit access yet, I'm going to start the process of
> requesting it. I named you as the person to approve my account
> creation Carlos.
>
> While that is happening if anyone else would like to apply this patch
> please feel free to :)
I have committed it on your behalf, with a couple of minor formatting
nits fixed in the commit message (double space after a full stop) and the
ChangeLog entry (full stop at the end of a sentence). Thanks for your
contribution.
Maciej