This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: When can we stop writing ChangeLogs?
- From: Florian Weimer <fweimer at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- Cc: Carlos O'Donell <carlos at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Mon, 07 Oct 2019 14:56:32 +0200
- Subject: Re: When can we stop writing ChangeLogs?
- References: <6ebd0e52-a18f-15fc-f4ab-cf2c3afc74e9@gotplt.org> <f656068c-1307-8041-fece-efbb81dfc093@linaro.org> <3bd4b069-e16b-af68-fb2f-17d2458bece5@redhat.com> <e2071ccb-2e31-cea4-84fc-e8353abe0674@gotplt.org> <878sq522xz.fsf@oldenburg2.str.redhat.com> <52634368-ee1e-23d1-1d61-de0057e03829@gotplt.org> <87ftkdzl4v.fsf@oldenburg2.str.redhat.com>
* Florian Weimer:
> * Siddhesh Poyarekar:
>
>> On 30/09/19 11:56 am, Florian Weimer wrote:
>>> I think we need to establish a procedure for commit message review as
>>> well. I would like to be able to tell, based on the posted patch, what
>>> the commit will look like exactly. Right now, we have a lot of variance
>>> there, and there have been quite a few surprises (apart from purely
>>> accidental pushes).
>>
>> We have git commit messages documented as one of the things that a
>> contributor needs to pay attention to in the Contributor Checklist, but
>> enforcement of review has been sketchy. I can't think of a better
>> solution at the moment than a review tool that requires reviewers to
>> flag the commit message as being OK.
>
> I'm looking for something far simpler here—a script that submitters and
> reviewers can run to see what's going to be committed, and some level of
> project consensus that this is how patches should be posted.
>
> Hopefully we can get to this point while still using email for patch
> submission and review.
Upon reconsideration, I think I can make git mailinfo work for me. This
means that I do not consider the lack of a tool a blocker anymore.
Thanks,
Florian