This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
- From: Florian Weimer <fweimer at redhat dot com>
- To: Petr Vorel <pvorel at suse dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 07 Oct 2019 15:11:55 +0200
- Subject: Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
- References: <20191007130749.29272-1-pvorel@suse.cz>
* Petr Vorel:
> Originally the public interface for getdents64 was declared in
> <unistd.h> in 51ea67d548. Later, b8b3d5a14e moved it to <dirent.h>.
>
> Fixes: b8b3d5a14e ("Linux: Move getdents64 to <dirent.h>")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> include/dirent.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/dirent.h b/include/dirent.h
> index 3736803bce..1f0121f3d9 100644
> --- a/include/dirent.h
> +++ b/include/dirent.h
> @@ -36,8 +36,7 @@ extern __ssize_t __getdirentries (int __fd, char *__restrict __buf,
> __off_t *__restrict __basep)
> __THROW __nonnull ((2, 4));
>
> -/* These functions are only implemented on Linux. The public
> - interface for getdents64 is declared in <unistd.h>. */
> +/* These functions are only implemented on Linux. */
> extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes)
> attribute_hidden;
> extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
Looks good to me, thanks. I assume you don't have commit access. I can
install the patch for you.
Florian