This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Contribution checklist v2

* Joseph Myers:

> On Mon, 7 Oct 2019, Carlos O'Donell wrote:
>
>> There is a difference between testing for commit vs. testing in general.
>
> A key thing about testing for commit is *describe the testing you did in 
> the commit message*.  That way, a reviewer has the information needed to 
> consider whether the testing described was sufficient for the patch in 
> question or not.

When you say “in the commit message”, do you mean that this
information should be committed to Git, too?

(I have no strong opinion on this matter, but I don't think it's
common practice in other projects.)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]