This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 28/31] Avoid compat symbols for totalorder in powerpc64le IEEE long double
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 15 Oct 2019 21:08:23 +0000
- Subject: Re: [PATCH 28/31] Avoid compat symbols for totalorder in powerpc64le IEEE long double
- Ironport-sdr: laJDRw3pQOYmpSwRzjAXzRvnTfFXtHJ/EaiYR5600BJvK64ttF0zscAOcObbc5xHjzhnjbfu69 RmFnU4BP8chEkft39QSCvMZFwqC6vblqrI+gqxQwAeqLodWo9Wjt9hm/coUpMBJwk1myLp985h AKIHG9HUGCHku2sngZhgtiV5V0TyAaAPbbabbq9zgBoZFQP6F/srhbZwRuGxInJ6Y9iY6Hl4RZ j7mK7xaM3fiE7JxC/xy07dtS089mfYWAUtAB6TcoPKQU3X4xhdbilpyGNWkZarOHJlA9Jc4hiu Kp0=
- Ironport-sdr: xwY70uqsXAanb2IZxU/s5jEfHm37uFrklyLs64zT3u6hBMSKtiECrevrOFEshwT61lUktk+G0w FsOCGkp4urQW0BMPzQ9uivD8OHc57Nc0XSpIsLLTcNjI/R5FSo0F/u40H09WRlt++/s3OMBvDz 2xuOakLAzjthfe5SoynXow5ZQUtNfIMNX9nF6uZGTdkVyLRf10UcJ5il3vYAgRXmXQo1W/IgMl JrbaPB0MOqUZOtW6mHG9hyE+zEjx2P5k0lT0Q8AsdA8xKxHYnlZzMaRDA++Q7omvo/fzM5agiF zBw=
- References: <20191015190529.11559-1-gabriel@inconstante.net.br> <20191015190529.11559-29-gabriel@inconstante.net.br>
On Tue, 15 Oct 2019, Gabriel F. T. Gomes wrote:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>
> On powerpc64le, the libm_alias_float128_other_r_ldbl macro is
> used to create an alias between totalorderf128 and __totalorderlieee128,
> as well as between the totalordermagf128 and __totalordermaglieee128.
>
> However, the totalorder* and totalordermag* functions changed their
> parameter type since commit ID 42760d764649 and got compat symbols for
> their old versions. With this change, the aforementioned macro would
> create two conflicting aliases for __totalorderlieee128 and
> __totalordermaglieee128.
>
> This patch avoids the creation of the alias between the IEEE long double
> symbols (__totalorderl*ieee128) and the compat symbols, because the IEEE
> long double functions have never been exported thus don't need such
> compat symbol.
This needs more explanation (in a comment in the relevant files). Are you
saying that libm_alias_float128_other_r_ldbl is presently either unused,
or used but expanding to empty, in all existing configurations using these
files (so it's not needed to create any existing compat aliases in any
configuration that has these functions either for long double or for
_Float128)?
--
Joseph S. Myers
joseph@codesourcery.com