This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ldconfig: handle .dynstr located in separate segment (bug 25087)

* Andreas Schwab:

> On Okt 16 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> * Andreas Schwab:
>>
>>> +		  && dyn_entry->d_un.d_val < segment->p_vaddr + segment->p_filesz)
>>
>>> +	  dynamic_strings = (char *) (file_contents + dyn_entry->d_un.d_val - loadoff);
>>
>> I think these lines are too long.  I also suspect that the condition
>> should be written as
>>
>>   dyn_entry->d_un.d_val - segment->p_vaddr < segment->p_filesz
>
> Ok.
>
>> Is it possible to write a test case for bug 25087?
>
> The broken layout is created by patchelf, but I have no idea how to
> replicate it without that.

I guess in this case, checking this in without a regression test is
fine.

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]