This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/4] Remove x64 _finite tests and references
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 18 Oct 2019 15:15:19 -0300
- Subject: Re: [PATCH 3/4] Remove x64 _finite tests and references
- References: <VI1PR0801MB2127879AB40C189C4483AD1F83E20@VI1PR0801MB2127.eurprd08.prod.outlook.com> <741cf0f9-f566-0833-c161-a4ddcb3b9f9d@linaro.org>
On 16/07/2019 15:19, Adhemerval Zanella wrote:
>
>
> On 26/06/2019 11:00, Wilco Dijkstra wrote:
>> Remove _finite tests and references from x86_64. Rather than calling
>> __exp_finite, use exp directly (since it's the same entry point).
>>
>> x86_64 builds and passes testsuite.
>>
>> ChangeLog:
>>
>> 2019-06-26 Wilco Dijkstra <wdijkstr@arm.com>
>>
>> * sysdeps/x86_64/fpu/Makefile: Remove all finite tests.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_exp2_core_sse4.S: Use exp.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_exp4_core_avx2.S: Use exp.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_exp8_core_avx512.S: Use exp.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_log2_core_sse4.S: Use log.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_log4_core_avx2.S: Use log.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_log8_core_avx512.S: Use log.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_pow2_core_sse4.S: Use pow.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_pow4_core_avx2.S: Use pow.
>> * sysdeps/x86_64/fpu/multiarch/svml_d_pow8_core_avx512.S: Use pow.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_expf16_core_avx512.S: Use expf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_expf4_core_sse4.S: Use expf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_expf8_core_avx2.S: Use expf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_logf16_core_avx512.S: Use logf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_logf4_core_sse4.S: Use logf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_logf8_core_avx2.S: Use logf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_powf16_core_avx512.S: Use powf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_powf4_core_sse4.S: Use powf.
>> * sysdeps/x86_64/fpu/multiarch/svml_s_powf8_core_avx2.S: Use powf.
>> * sysdeps/x86_64/fpu/svml_d_exp2_core.S: Use exp.
>> * sysdeps/x86_64/fpu/svml_d_log2_core.S: Use log.
>> * sysdeps/x86_64/fpu/svml_d_pow2_core.S: Use pow.
>> * sysdeps/x86_64/fpu/svml_finite_alias.S: Remove.
>> * sysdeps/x86_64/fpu/svml_s_expf4_core.S: Use expf.
>> * sysdeps/x86_64/fpu/svml_s_logf4_core.S: Use logf.
>> * sysdeps/x86_64/fpu/svml_s_powf4_core.S: Use powf.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx2-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx2-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx2.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx512-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx512-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-avx512.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-double-libmvec-alias.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx2-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx2-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx2.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx512-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx512-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-avx512.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-main.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias-mod.c: Remove.
>> * sysdeps/x86_64/fpu/test-float-libmvec-alias.c: Remove.
>> * sysdeps/x86_64/fpu/test-libmvec-alias-mod.c: Remove.
>
> LGTM.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
I chatted with Wilco and I will commit this patch shortly on his
behalf.