This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v5 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Alistair Francis <alistair dot francis at wdc dot com>
- Cc: <libc-alpha at sourceware dot org>, <alistair23 at gmail dot com>
- Date: Mon, 21 Oct 2019 16:48:26 +0000
- Subject: Re: [PATCH v5 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
- Ironport-sdr: nm2R9aScFIJ106foQQaB2074UGc4dCJWRmfUHvq4zSB+LHxaSI3ylRAK3sfAUgb2awMn0jPMVo fvfYb2kk0j2IGaA+oU+qmJxQpL9vx9hLOoZfRWq6ucCXEce7zdqOZSTv87E6hrdGAsvPSeUSFZ ROTQRK5YwOkG6l1CSs4mU7IC9TPAxvBIfIWc8qiILlPSP/vXjHih8HFWlxzp03UZbwGjG+YFh8 6kDl8QazSofEvB3Ax7EhkvL/GhTnkBtcjxDH1TMKnzjQQJREj3S7io/9bXH7wScwYZotacvMAm Ulk=
- Ironport-sdr: Ziwpsp/S4FX8ziCIaKadtIOOgTYcue0m6MUcRuOt6ziNU7wxvNmT6NXnX8821kMgRFYA60Mvmc lemk92mS18OW5bmz1bRgz0rXtVM1YPUojW+OqdQRFVwXtpePXT2N0fGz7W+jpB0dkTPJMNPjFk +jRwTfwlW2T04GL1+VbXXvvFpSdAdVOOUE1fZkxL+P9t9KhfHsvdhvqLL3osGdAXyMFeCIs847 5sajh+2oLH52yOCttLTeLW2SXoYkbG/cccBocanF5du8MQ4s7bSYBuLwEUPaK2GHhAlT+ulavy E7Q=
- References: <20191021154627.23713-1-alistair.francis@wdc.com>
On Mon, 21 Oct 2019, Alistair Francis wrote:
> On a 32-bit platform with a 64-bit ino_t type (__INO_T_MATCHES_INO64_T
> defined) we want to update the stat struct to remove the padding as it
> isn't required. As we don't have the padding we also need to update the
> overflow checker to not access the undefined members.
> ---
> This change was tested by running user space tests for RV32 and RV64.
>
> v4:
> - Move the assert to: sysdeps/unix/sysv/linux/generic/stat-check.c
This needs Makefile changes to cause this file to be compiled as part of
the glibc build.
--
Joseph S. Myers
joseph@codesourcery.com