This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH v2 2/3] elf: avoid redundant sort in dlopen
- From: David Kilroy <David dot Kilroy at arm dot com>
- To: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Thu, 24 Oct 2019 10:33:49 +0000
- Subject: [PATCH v2 2/3] elf: avoid redundant sort in dlopen
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8zY/4BsDBhO17rlr+l07xKLODvQZIrfDyFCLf7X3/sI=; b=bS+n6WfCZVNsAcxsUpRg5qypest1BuFZ0BjM30nVU0f3QPQfXPbtN5imUvj91SKBvpleJNio50/Rp25GOuT3CrlcwqkZAoay7I5mCaO8P3AD7Kh0AlrmpoiMdFC9IPMnl+cBeT3DWIZVXuE7tzAan2OA/u+gfTFtyJscF/1i310/njdHoMupas3ywdGf0qrr9ZCNDkViz4iiPojW37xATesNScO0FY06UVx1YXFwqp1OnqGnXRWFm67OIbPzSRdgrGCbZN4lBpq39NNqycpRoatU39yxnob7Q0O3rHzMSt/GuXxcvDLfyJ8BHv9LLGFVwaoUnrOqf/nN8E3JZrn3GA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J0rD5sGx0yqJsF2TcoTra8uGgz0qRv1E7dVmfiOWQXuvEtzYrYfinfqjjYRR3nz1jFVB4ds32ftUvU6pyQmXpt16irjf+VTeCLa32yNge/zlCUkovBZsxZXKAFL2dfl97IQAMCsKwy4nDIxeL34HNeBk5KeODgt3KEel6Eh5DDAqtUaulIM1lpJwhT74Ri6MUQy93d85nZcY48Wn4dGAe4+TkibDTGQyfiHOBqRcKcUU0OTrQ+Fy1ibbqOeraIr0Mcs/6TTjEsF2+In97t8aeE1uMQseueZzls5kX7n0g2JfSDgFJjoB3VqSsj2evRlZRX8Q0JbJzpYtaCQZKbPz4A==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=David dot Kilroy at arm dot com;
- References: <cover.1571755115.git.david.kilroy@arm.com>
l_initfini is already sorted by dependency in _dl_map_object_deps(),
so avoid sorting again in dl_open_worker().
Tested by running the testsuite on x86_64.
---
elf/dl-open.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/elf/dl-open.c b/elf/dl-open.c
index 03f2b86..4df2e3f 100644
--- a/elf/dl-open.c
+++ b/elf/dl-open.c
@@ -326,7 +326,6 @@ dl_open_worker (void *a)
l = new->l_initfini[++j];
}
while (l != NULL);
- _dl_sort_maps (maps, nmaps, NULL, false);
int relocation_in_progress = 0;
--
2.7.4