This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [review v3] localedef: Add verbose messages for failure paths.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <gnutoolchain-gerrit at osci dot io>
- Cc: <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Fri, 25 Oct 2019 14:56:08 +0000
- Subject: Re: [review v3] localedef: Add verbose messages for failure paths.
- Ironport-sdr: fc1uMABDrsGzh1ehk7h0cPvWWfsVAy8Sy26lQEt0z2GefWEMYfeqflCiGsY412+SgiX/1Q9GWt EBcK+8sF+PlNubAy43uLx5qlUz2tBzIBDM7nArd0D7Sis4Z5H4lYjNVnLQIhLM1VdC5rMHd8nv v5nz3ovc0vrhBDP8b8I5zyeW1Z22HHJcdRSR12qDdnlquCxrxpDDxp/BRyuizadHHCKqGjNBrY lerMOaFQt5+wLY3RkWhzPyBzWpStx41xagzWdvI6nn10CRVBNZmhDibRQFokmcJ44QAavNyQC1 pQE=
- Ironport-sdr: mvbNxX+S8mhkTuSvIUMuAmp8mnI+u6vcYlYjtDPfesD9/Xyx4gmpw/DeZ/S7ZArGXK49Z/AaLF EhnGdLLbbhxc7ydezq8vwOcS1dthlTXyhVA/vmwLqbjRwCBFha6Tevj/6xCsVAONPWPs8B54zf 5v7umn9BLDwyZt5mSEcYptgSpcs6Y/FhyU0xeTIbXNtToqw21WRG29J7Ylhs9AysUHPTBKJWqP uZuMDJ8oaEtppjhiVB1FI5dgfvOEqPT7D+3NrnyHJUpnzmzrj+Ut1hg8fXaKq/fKJkPL0QRPct 81I=
- References: <gerrit.1571944987000.I28b9f680711ff00252a2cb15625b774cc58ecb9d@gnutoolchain-gerrit.osci.io> <20191025132558.04595204C9@gnutoolchain-gerrit.osci.io>
On Fri, 25 Oct 2019, Carlos O'Donell (Code Review) wrote:
> https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/303/1/locale/programs/localedef.c@531
> PS1, Line 531: _("failed to allocate space for compiled locale path"));
> > I think this line is too long. […]
> Done
This is a meta-comment on the formatting of these emails and a test of
email replies to gerrit:
"PS1, Line 531:" is not helpful, and just makes the lines in these
messages longer. Quoted text should just use normal "> " to quote it
(with the additional leading character "+", "-" or " " when being quoted
as part of a diff hunk).
--
Joseph S. Myers
joseph@codesourcery.com