This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] nptl: Move nanosleep implementation to libc
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 06 Nov 2019 14:04:18 +0100
- Subject: Re: [PATCH 1/3] nptl: Move nanosleep implementation to libc
- References: <20191106125245.28102-1-adhemerval.zanella@linaro.org>
* Adhemerval Zanella:
> diff --git a/nptl/Versions b/nptl/Versions
> index adbd4fa589..92291bf49e 100644
> --- a/nptl/Versions
> +++ b/nptl/Versions
> - GLIBC_2.2.6 {
> - # Cancellation wrapper
> - __nanosleep;
> - }
Sorry, this change is not correct because it removes the GLIBC_2.2.6
symbol version. Old programs will fail to load as a result, not due to
the missing __nanosleep@@GLIBC_2.2.6 (we removed that check, and the
symbol in libc is sufficient), but due to the overall GLIBC_2.2.6 check
for libpthread. You can use __libpthread_version_placeholder as a stub
symbol to keep that version alive.
Thanks,
Florian