Re: [review v2] hurd: Remove lingering references to the time function

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2019-11-07 4:07 a.m., Florian Weimer wrote:
> * Florian Weimer:
> 
>> Florian Weimer has posted comments on this change.
>>
>> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/505
>> ......................................................................
>>
>>
>> Patch Set 2: Code-Review+2
> 
> Not sure what was going on here.  The changeset did not show up as
> merged in Gerrit after Gerrit saw it pushed.  Gerrit created a v2, and I
> had to +2 it so that it got merged.
> 
> This did not happen with the other change,
> <https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/506>, even though
> pushing that created a v2 as well.
> 
> I added Reviewed-By: lines in both cases.
> 
> Simon, would you please have a look?  Is this an artifact of using
> Gerrit in non-push mode?  Have you seen something similar with GDB?

Yes, we have seen the same maybe 2-3 times (so it was more the exception
than the norm).  Gerrit marked the change as merged, but it did not
close it.  And as you said, doing some label change (like +2) seemed to
make Gerrit re-evaluate the state of the change correctly.

So it's a known bug.  I haven't really looked into it because it doesn't
happen often, so it's hard to reproduce.

Simon