This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review] nptl: Add mutex-internal.h
- From: "Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fweimer at redhat dot com>
- Date: Thu, 7 Nov 2019 15:59:36 -0500
- Subject: [review] nptl: Add mutex-internal.h
- Auto-submitted: auto-generated
- References: <gerrit.1573136666000.I30a22c3e3497805fd6e52994c5925897cffcfe13@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/518
......................................................................
Patch Set 1:
(1 comment)
I think this goes in the right direction, but I really dislike the header file name.
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/518/1/sysdeps/nptl/bits/mutex-internal.h
File sysdeps/nptl/bits/mutex-internal.h:
https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/518/1/sysdeps/nptl/bits/mutex-internal.h
PS1:
I don't think we should use mutex-internal.h as the name of an *installed* header. So far, we used “internal” headers for headers which cross subsystem boundaries, but which are still, well, internal to glibc.
Given that this is now essentially one of these per-type headers, maybe use our naming convention for them?
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I30a22c3e3497805fd6e52994c5925897cffcfe13
Gerrit-Change-Number: 518
Gerrit-PatchSet: 1
Gerrit-Owner: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-CC: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 20:59:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment