[review] hppa: Remove unrequired nptl headers

["Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>]

Florian Weimer has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/522
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

The commit message could mention that the pthreadP.h is just a vaguely-related cleanup.

https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/522/1/sysdeps/unix/sysv/linux/hppa/pthread.h 
File sysdeps/unix/sysv/linux/hppa/pthread.h:

https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/522/1/sysdeps/unix/sysv/linux/hppa/pthread.h 
PS1: 

I really like this.


https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/522/1/sysdeps/unix/sysv/linux/hppa/pthreadP.h 
File sysdeps/unix/sysv/linux/hppa/pthreadP.h:

https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/522/1/sysdeps/unix/sysv/linux/hppa/pthreadP.h@a14 
PS1, Line 14: 
 9 |                                         const pthread_condattr_t *cond_attr);
10 | extern int __pthread_cond_signal_internal (pthread_cond_t *cond);
11 | extern int __pthread_cond_timedwait_internal (pthread_cond_t *cond,
12 |                                              pthread_mutex_t *mutex,
13 |                                              const struct timespec *abstime);
14 > extern int __pthread_cond_wait_internal (pthread_cond_t *cond,
15 |                                         pthread_mutex_t *mutex);
16 | #endif

All this declarations seem unused to me, so this could go into a separate patch to be merged earlier. Your call.



-- 
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I236cfceb5656cfcce42c9e367a4f6803e2abd88b
Gerrit-Change-Number: 522
Gerrit-PatchSet: 1
Gerrit-Owner: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 21:08:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment