Re: RFC: test-in-container vs ld.so

[Florian Weimer <fw at deneb dot enyo dot de>]

* DJ Delorie:

> So... should we run containerized tests without ld.so?

Yes, absolutely. It's one of the benefits of running things in a
container.

But I think we are already doing that?  test-container is run via
ld.so, but the actual test is not?

> 1. Are there tests that *need* the env/ld.so handling within the
> container?  (not counting test-specific environment variables, I mean
> the environment variables we pass to *every* test)

We need to set up a predictable locale configuration.  But GCONV_PATH
and LOCPATH should *not* be set.

> 2. how complicated would it be to remove those from the makefile
> rules?  Alternatively, I suppose test-container itself could remove
> them, but better not to hide that logic.

I suspect the removalof LC_*, LANG etc. variables should be done in
test-container, just for convenience.

Then we can just drop $(run-program-env) because it is defined as:

# $(run-program-env) is the default environment variable settings to
# use when running a program built with the newly built library.
run-program-env = GCONV_PATH=$(common-objpfx)iconvdata \
		  LOCPATH=$(common-objpfx)localedata LC_ALL=C