This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: How to keep Reviewed-by lines in git commits with gerrit.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Tue, 12 Nov 2019 17:40:44 +0000
- Subject: Re: How to keep Reviewed-by lines in git commits with gerrit.
- Ironport-sdr: vogSBVvYNoN3e2ci0y1plNY4dOOoQAvmUg8qfrORL2fDoPL72h9jqPfnxJUdvWCopoofvADXcH R0a6DKdDoNimH/AmlID7FE2O9YY/t0BUX+QUTlz3b6fD5SMEzSPuODyDXQHxb4UhhpvoN9pDVb rjCMOiiz8QIREq0QZYomyAqWS2UbtNWHH6LRfYTNyVdvWItj2Fd2rtiViRShpQG3ff/fUvL1Eg y8dh+mDfQnPr02l4eRS66kqqPkROAZ+idEwli7HqOQP3+n8E6Ep17LMYp9M4U2UEZ+m6xRVRSG TXk=
- Ironport-sdr: Ju2byXL/KIz/abHh4oqAwvmlztxQtAFtB7lo+Ped+X8Su2a53gqrYbzK08vDY/f97bnT1+gI9D IcDaekgOYlNOjveDulNCAipcTetb5CVJ9+BONewYLUTT1fAElRcAdzHRR7IbbvkLG/25MCemBu C6TwL0/h6GAdkVfwwSgefiUaoGlmhsYTKCO+lui/vDQPc9SvH4/p4KCs7H+ew7S8mA185O1OQq ivDkS5vycxO8uATxyjGKhHfNB7SoDd6L6DwcHbbFbANj/omKInlBlEmrEIuZXZd6JgMGTTg/qp tac=
- References: <7b4aa5d2-14e7-c0aa-a258-bbd60455fae5@redhat.com>
On Tue, 12 Nov 2019, Carlos O'Donell wrote:
> In the meantime I can do two things as a reviewer to help you keep
> the Reviewed-by lines.
>
> 1. If I am about to grant +2 review I edit the commit and generate
> a new patchset version, and add my Reviewed-by line.
> 2. I submit my review of +2.
>
> Then when you push, you just need to make sure your new commit message
> matches and it should close the review.
That seems overly complicated. I thought the Change-Id was how gerrit
told whether something was the same change, so would have expected that
simply adding the Reviewed-by to the commit message when doing the final
commit, but keeping the same Change-Id, would suffice, without extra patch
set versions being needed unless there is an actual need for a new version
to be reviewed.
--
Joseph S. Myers
joseph@codesourcery.com