Re: How to keep Reviewed-by lines in git commits with gerrit.

[Florian Weimer <fw at deneb dot enyo dot de>]

* Carlos O'Donell:

> If we ever switch to supporting Gerrit, then we will automatically
> gain the Reviewed-by: lines depending on the configuration of Gerrit.
> Reviewers would understand this as part of doing their reviews and
> granting the review +1/+2.
>
> In the meantime I can do two things as a reviewer to help you keep
> the Reviewed-by lines.
>
> 1. If I am about to grant +2 review I edit the commit and generate
>    a new patchset version, and add my Reviewed-by line.
> 2. I submit my review of +2.
>
> Then when you push, you just need to make sure your new commit message
> matches and it should close the review.

We should not edit the commit message manually after it has been
reviewed.

Either it is automatically added by the review tool, or we need to
gather patch review statistics from the review tool.

The latter has the advantage that post-commit review also counts,
which is not possible if we only consider Reviewed-By: lines in
commits.