This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix null pointer in mtrace

From: liqingqing <liqingqing3 at huawei dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: liusirui <liusirui at huawei dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "carlos at redhat dot com" <carlos at redhat dot com>, "siddhesh at gotplt dot org" <siddhesh at gotplt dot org>, "dj at redhat dot com" <dj at redhat dot com>, Hushiyuan <hushiyuan at huawei dot com>
Date: Wed, 13 Nov 2019 09:28:00 +0800
Subject: Re: [PATCH] fix null pointer in mtrace
References: <1573550539-34259-1-git-send-email-liusirui@huawei.com> <fcd6b190-6e21-040b-edea-4c91377be814@huawei.com> <87a791qsuo.fsf@oldenburg2.str.redhat.com>


On 2019/11/12 18:41, Florian Weimer wrote:
> * liqingqing:
> 
>> I had tested this scenario, it seems like that the fprintf and other
>> file operation function do not check the invalid argument like the
>> null pointer.  does any one knows why fprintf do not check the input?
> 
> It's not required by the standard because violating preconditions
> results in undefined behavior.  Sloppily written code with such bugs
> tends to not check error returns from functions, either.  This means if
> we added a null check for the stream argument to fprintf (e.g., failing
> with EINVAL in that case), it would only obscure the problem and make
> diagnosis even more difficult.
> 
> Thanks,
> Florian
> 
clear, thank you Florian

References:
- [PATCH] fix null pointer in mtrace
  - From: Liusirui
- Re: [PATCH] fix null pointer in mtrace
  - From: liqingqing
- Re: [PATCH] fix null pointer in mtrace
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]