This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review v2] nptl: Add tests for internal pthread_rwlock_t offsets
- From: "Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fweimer at redhat dot com>
- Date: Thu, 14 Nov 2019 09:35:03 -0500
- Subject: [review v2] nptl: Add tests for internal pthread_rwlock_t offsets
- Auto-submitted: auto-generated
- References: <gerrit.1573136666000.Iccc103d557de13d17e4a3f59a0cad2f4a640c148@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/516
......................................................................
Patch Set 2:
(2 comments)
I ran this through a full build-many-glibcs.py run, and the results look good.
| --- nptl/pthread_rwlock_init.c
| +++ nptl/pthread_rwlock_init.c
| @@ -37,8 +42,19 @@ __pthread_rwlock_init (pthread_rwlock_t *rwlock,
| + ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_rwlock_t, __data.__wrphase_futex,
| + __PTHREAD_RWLOCK_WRPHASE_FUTEX_OFFSET);
| + ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_rwlock_t, __data.__writers_futex,
| + __PTHREAD_RWLOCK_WRITERS_FUTEX_OFFSET);
| + ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_rwlock_t, __data.__cur_writer,
| + __PTHREAD_RWLOCK_CUR_WRITER_OFFSET);
| + ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_rwlock_t, __data.__shared,
| + __PTHREAD_RWLOCK_SHARED_OFFSET);
| + ASSERT_PTHREAD_INTERNAL_OFFSET (pthread_rwlock_t, __data.__flags,
| + __PTHREAD_RWLOCK_FLAGS_OFFSET);
PS1, Line 51:
Done
| +
| const struct pthread_rwlockattr *iattr;
|
| iattr = ((const struct pthread_rwlockattr *) attr) ?: &default_rwlockattr;
|
| memset (rwlock, '\0', sizeof (*rwlock));
|
| rwlock->__data.__flags = iattr->lockkind;
|
| --- sysdeps/mips/nptl/pthread-offsets.h
| +++ sysdeps/mips/nptl/pthread-offsets.h
| @@ -14,0 +27,10 @@ # define __PTHREAD_RWLOCK_WRPHASE_FUTEX_OFFSET 8
| +# define __PTHREAD_RWLOCK_WRITERS_FUTEX_OFFSET 12
| +# define __PTHREAD_RWLOCK_CUR_WRITER_OFFSET 28
| +# if __BYTE_ORDER == __BIG_ENDIAN
| +# define __PTHREAD_RWLOCK_SHARED_OFFSET 26
| +# define __PTHREAD_RWLOCK_FLAGS_OFFSET 27
| +# else
| +# define __PTHREAD_RWLOCK_SHARED_OFFSET 25
| +# define __PTHREAD_RWLOCK_FLAGS_OFFSET 24
| +# endif
| +#endif
PS1, Line 36:
Done
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: Iccc103d557de13d17e4a3f59a0cad2f4a640c148
Gerrit-Change-Number: 516
Gerrit-PatchSet: 2
Gerrit-Owner: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-Reviewer: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 14:35:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Florian Weimer <fweimer@redhat.com>
Comment-In-Reply-To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Gerrit-MessageType: comment