This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] misc: Set generic pselect as ENOSYS



On 14/11/2019 16:28, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> diff --git a/misc/pselect.c b/misc/pselect.c
>> index 76ded850a5..7296b6ef61 100644
>> --- a/misc/pselect.c
>> +++ b/misc/pselect.c
>> @@ -34,43 +34,8 @@ int
> 
> Missing header file adjustments?

Hum, which adjustment are you referring exactly?

> 
>> diff --git a/sysdeps/unix/sysv/linux/microblaze/pselect.c b/sysdeps/unix/sysv/linux/microblaze/pselect.c
>> new file mode 100644
>> index 0000000000..62430ca69a
>> --- /dev/null
>> +++ b/sysdeps/unix/sysv/linux/microblaze/pselect.c
> 
>> +  /* The fallback uses 'selects' which shows the race condition regarding
> 
> Typo: 'selects' (I think)

Ack.

> 
>> index acda3e0cdd..77a5179925 100644
>> --- a/sysdeps/unix/sysv/linux/pselect.c
>> +++ b/sysdeps/unix/sysv/linux/pselect.c
>> @@ -23,16 +23,6 @@
>>  #include <kernel-features.h>
>>  #include <sysdep-cancel.h>
> 
> Again I suspect header file cleanups are possible.
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]