This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: For the practical sake of the gerrit experiment --- Don't change the commit message.
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Sat, 16 Nov 2019 15:42:29 +0100
- Subject: Re: For the practical sake of the gerrit experiment --- Don't change the commit message.
- References: <5ecfd968-2cae-5bfa-da19-b0b2d75c3126@redhat.com>
* Carlos O'Donell:
> Florian,
>
> I think from a practical stand point we don't need to record
> the Reviewed-by: lines for the reviews done in Gerrit.
>
> Lets just pretend that they would get added in the future.
> This way we can focus on what the real workflow would be like.
>
> This way if you get at +2 in Gerrit just assume you can push
> without all the other work.
>
> Does this sound OK to you?
Fine with me. It reduces mailing list clutter because a patch
approval does results only in +2 and pushed notification, not +2, new
version, +2 again, push, so a net reduction by two messages.