This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review] Use DEPRECATED_SCANF macro for remaining C99-compliant scanf functions
- From: "Florian Weimer (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fweimer at redhat dot com>
- Date: Thu, 21 Nov 2019 11:13:24 -0500
- Subject: [review] Use DEPRECATED_SCANF macro for remaining C99-compliant scanf functions
- Auto-submitted: auto-generated
- References: <gerrit.1574346742000.I706b344a3fb50be017cdab9251d9da18a3ba8c60@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Florian Weimer has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/698
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
| --- wcsmbs/wchar.h
| +++ wcsmbs/wchar.h
| @@ -680,18 +680,18 @@ extern int vwscanf (const wchar_t *__restrict __format,
| __gnuc_va_list __arg)
| /* __attribute__ ((__format__ (__wscanf__, 1, 0))) */;
| /* Read formatted input from S into argument list ARG. */
| extern int vswscanf (const wchar_t *__restrict __s,
| const wchar_t *__restrict __format,
| __gnuc_va_list __arg)
| __THROW /* __attribute__ ((__format__ (__wscanf__, 2, 0))) */;
|
| -# if !defined __USE_GNU \
| +# if !__GLIBC_USE (DEPRECATED_SCANF) \
PS1, Line 688:
Maybe reference fwscanf above here in a comment?
| && (!defined __LDBL_COMPAT || !defined __REDIRECT) \
| && (defined __STRICT_ANSI__ || defined __USE_XOPEN2K)
| # ifdef __REDIRECT
| extern int __REDIRECT (vfwscanf, (__FILE *__restrict __s,
| const wchar_t *__restrict __format,
| __gnuc_va_list __arg), __isoc99_vfwscanf)
| /* __attribute__ ((__format__ (__wscanf__, 2, 0))) */;
| extern int __REDIRECT (vwscanf, (const wchar_t *__restrict __format,
| __gnuc_va_list __arg), __isoc99_vwscanf)
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I706b344a3fb50be017cdab9251d9da18a3ba8c60
Gerrit-Change-Number: 698
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriel F. T. Gomes <gabriel@inconstante.net.br>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 16:13:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment