This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Remove duplicate inline implementation of issignalingf
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul A. Clarke" <pc at us dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>, <adhemerval dot zanella at linaro dot org>
- Date: Thu, 21 Nov 2019 21:39:13 +0000
- Subject: Re: [PATCH v2] Remove duplicate inline implementation of issignalingf
- Ironport-sdr: 2l00or5RRa8B3DRI74yyNDYg7IU/McFCBCFAW3flifWlmTPaACk0B73qqYwYLHOe4wKWvPzn1b yspjTzkV60nExvxAdsDPWu99NIr9YVqIJUexC60BNDgGZuDB45uPW+DTN+jsQopTZRJXAMZaOF 36VIbMPudmzYyWBwC0Sp0Nkni7jBPq60Es8NPE4FNtX7uEyeBnIZVCxzxFWnTRbMV13UEbzdS4 I/A/mvgoGq6qqpqp2MW9eZeLhWBU9FOj0zdyFPg3+Vnjb0UR0nMZJQiOO+OjAJ5hjvoPz6hwOj mRY=
- Ironport-sdr: jbiMVOAkuC61VhWWQnjdsyo5b3PogPaxAXZZpsLjEvTW66HRFznF/9PcRbwMjtD1QKJMECDbnA fkmBE8WbIpQ7JpyrdqZiEOBlOBqgzjzNHcoiUTAlSd+pdQKE9pITQCeZS3dXNA0SujwzonT0Oo rVzx5U4MoJXsZRSwl0E09xuek0WHTwyf1SK5+G7566E79gj86lgJNvE2FNFnPPdLi++O7F22UG +KGD1EB1f++0E+6zQvaNuzSIZC1hnXXM/b8kRUB+0W5eJuqXPkBHxAHcho1T11F/cqcwrIvmNq ErE=
- References: <1574371456-1788-1-git-send-email-pc@us.ibm.com>
On Thu, 21 Nov 2019, Paul A. Clarke wrote:
> From: "Paul A. Clarke" <pc@us.ibm.com>
>
> Very recent commit 854e91bf6b4221f424ffa13b9ef50f35623b7b74 enabled
> inline of issignalingf() in general (__issignalingf in include/math.h).
> There is another implementation for an inline use of issignalingf
> (issignalingf_inline in sysdeps/ieee754/flt-32/math_config.h)
> which could instead make use of the new enablement.
>
> Replace the use of issignalingf_inline with __issignaling. Using
> issignaling (instead of __issignalingf) will allow future enhancements
> to the type-generic implementation, issignaling, to be automatically
> adopted.
This version is OK.
--
Joseph S. Myers
joseph@codesourcery.com