This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 08/30] ldbl-128ibm-compat: Add wide character scanning functions
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- To: Paul E Murphy <murphyp at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 22 Nov 2019 19:34:13 -0300
- Subject: Re: [PATCH v2 08/30] ldbl-128ibm-compat: Add wide character scanning functions
- References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-9-gabriel@inconstante.net.br> <de4e5cad-6834-e4af-4ffa-49d20901b72d@linux.ibm.com> <20191111113336.3b4393a4@tereshkova.br.ibm.com>
On Mon, 11 Nov 2019, Gabriel F. T. Gomes wrote:
>On Mon, 04 Nov 2019, Paul E Murphy wrote:
>>
>>With exception to some minor comments in my previous reviews, are there
>>any additional suggestions from the community? The *printf and *scanf
>>patches look ready to commit.
>
>I'm running patches 1 to 8 with build-many-glibcs.py once again before I
>commit them, which I plan to do after the test is over. I think they got
>a lot of feedback, specially if you count the initial patches sent before
>Zack's refactoring of vfprinf_internal and vfscanf_internal, and have
>converged to this version based on community suggestions and guidance. :)
I have finally committed patches 1 to 8 (after testing with b-m-g and
applying your suggestions: delay the definition of LDBL_IBM128_VERSION to
the last patch; guard the test in elf/tst-addr1.c (actually removed the
change); update copyright years).
Thanks.