This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Compile elf/rtld.c with -fno-tree-loop-distribute-patterns.
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 25 Nov 2019 13:45:24 -0700
- Subject: Re: [PATCH] Compile elf/rtld.c with -fno-tree-loop-distribute-patterns.
- Ironport-sdr: krvUv7KUFlWrGwhbp8yExDP3efXI7tlZboBJWf5F8BEbN5OFpXiVQC/Rjc4mEoeM43fOitHmVx /YvODk0GsYr2nk75HJi9Hd0Iw/6+Q7YTCFwfvDe0qsqRWgVUivsG5dG4jd8LzOh580tlrcFI/B tFBt/b6gPS2yfuOG5L2lV+kTlGXldu5gR5omYH348iYolHGyCV6WSgdXDQR4iugXXYd3CaIqVk 8dvNV2nNBy8SQhPZzLqAabJXJfRu6Jt0phj74TdDUvAPlMeUGywBHvqHNBZIP3BXk5/QxKHDK9 NR4=
- Ironport-sdr: OowHos3vWy4BA7OUVGOjvK2N1cNwbSzXPnTXkD/Nt+jldQlgQIpBzvL+o8J/XhhKVP0kGAm22Q W461PLcjZxHoRgRGCa36ho1KPR5YVBwQ7TWn7yMMNcwujbSvMphWAcukq+8oBAqD/7OYi7PDTX Vahh/Mg2EOvofMrs5objc1jv18xnALzh04rRo+exkFfXu0Wm1LWhC7La+baP0HHHpabSPsyxPd E9eDPVFQmBNdli46iIOqq6MsbUdfDn5tC1TqEVp1eAjz4ksm8DKjsDo4vgwc2nWKyz1rRq76hT wNg=
- References: <20191121021040.14554-1-sandra@codesourcery.com> <87ftie912x.fsf@mid.deneb.enyo.de> <50c290f5-ab71-ce00-cda2-a953eea29750@codesourcery.com> <877e3obco4.fsf@mid.deneb.enyo.de>
On 11/25/19 1:08 AM, Florian Weimer wrote:
I had hoped we could write something like this at the start of
elf/rtld.c:
#ifndef PI_STATIC_AND_HIDDEN
# pragma GCC optimize ("no-tree-loop-distribute-patterns")
#endif
Then the optimization would still be applied on the targets where it
is safe to do so.
Well, I could certainly hack up and test a new patch to do that, if that
is the recommended approach. But I see no other existing uses of
"pragma GCC optimize" anywhere in glibc other than in a few test cases,
while elf/Makefile already specifies -fno-tree-loop-distribute-patterns
on dl-tunables.c in the same way I added it for rtld.c, so my original
patch seems more consistent with current practice.
But I don't have a strong opinion about this and would appreciate
feedback from others.
Same here. I just want this bug fixed and will do it in whatever way
the community agrees on. As I said, the dynamic linker is currently
completely broken on nios2 when built with GCC 10.
-Sandra