This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/7] linux: Refactor sched_getcpu in terms of getcpu
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 01 Dec 2019 15:22:51 +0100
- Subject: Re: [PATCH 6/7] linux: Refactor sched_getcpu in terms of getcpu
- References: <20191129210327.26434-1-adhemerval.zanella@linaro.org> <20191129210327.26434-6-adhemerval.zanella@linaro.org>
* Adhemerval Zanella:
> diff --git a/sysdeps/unix/sysv/linux/sched_getcpu.c b/sysdeps/unix/sysv/linux/sched_getcpu.c
> index 65dd9fdda7..3646c8b713 100644
> --- a/sysdeps/unix/sysv/linux/sched_getcpu.c
> +++ b/sysdeps/unix/sysv/linux/sched_getcpu.c
> @@ -17,23 +17,11 @@
>
> #include <errno.h>
> #include <sched.h>
> -#include <sysdep.h>
> -
> -#ifdef HAVE_GETCPU_VSYSCALL
> -# define HAVE_VSYSCALL
> -#endif
> -#include <sysdep-vdso.h>
>
> int
> sched_getcpu (void)
> {
> -#ifdef __NR_getcpu
> unsigned int cpu;
> - int r = INLINE_VSYSCALL (getcpu, 3, &cpu, NULL, NULL);
> -
> + int r = __getcpu (&cpu, NULL);
> return r == -1 ? r : cpu;
> -#else
> - __set_errno (ENOSYS);
> - return -1;
> -#endif
> }
I wonder if the current state is a useful performance optimization.