This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 1/7] Fix __libc_signal_block_all on sparc64
- From: Andreas Schwab <schwab at suse dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 11 Dec 2019 09:51:08 +0100
- Subject: Re: [PATCH v3 1/7] Fix __libc_signal_block_all on sparc64
- References: <20191210183221.26912-1-adhemerval.zanella@linaro.org>
On Dez 10 2019, Adhemerval Zanella wrote:
> @@ -53,15 +54,16 @@ __clear_internal_signals (sigset_t *set)
> __sigdelset (set, SIGSETXID);
> }
>
> -#define SIGALL_SET \
> - ((__sigset_t) { .__val = {[0 ... _SIGSET_NWORDS-1 ] = -1 } })
> +static const sigset_t sigall_set = {
> + .__val = {[0 ... _SIGSET_NWORDS-1 ] = -1 }
> +};
Why do you need that static object? Doesn't it suffice to make the
compound literal const?
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."