This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 01/11] ldbl-128ibm-compat: Fix selection of GNU and ISO C99 scanf


On Mon, 09 Dec 2019, Paul E Murphy wrote:

>There are two tests wrapped in each: One to verify the headers select 
>the appropriate variant, secondly verifying the long double 
>implementation is correct.  The former is sometimes more complicated 
>than ibm128 or ieee128.

Right.

>I am not suggesting this work be included in this patchset, but would it 
>be approaching something like `assert (&(scanf) == &FPTR_EXPECTED 
>(scanf))` to this and similar printf tests (e.g fortified printf)?  Such 
>could quickly tell us if we need to update our tests.

Sounds good, maybe we could write something similar to elf/tst-addr1.c [1],
with hardcoded function names.

[1] https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/tst-addr1.c;h=68ff74aabd4dbe5b4dc1c98ebd2df2f66e080890;hb=HEAD


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]