This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions

From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
To: Paul E Murphy <murphyp at linux dot ibm dot com>
Cc: <libc-alpha at sourceware dot org>
Date: Fri, 13 Dec 2019 18:13:22 -0300
Subject: Re: [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions
References: <20191203170540.18428-1-gabriel@inconstante.net.br> <20191203170540.18428-3-gabriel@inconstante.net.br> <924787d8-daa3-aca6-c042-908f5b1c4a22@linux.ibm.com>

On Mon, 09 Dec 2019, Paul E Murphy wrote:

>On 12/3/19 11:05 AM, Gabriel F. T. Gomes wrote:
>> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>> 
>> +  /* For ISO C99, scan the single-precision value with "%as" to test
>> +     that __isoc99_*scanf ignores the 's'.  For DEPRECATED_SCANF, do not
>> +     use "%as", because that would try to scan a string and allocate
>> +     space for it.  */
>> +#if __GLIBC_USE (DEPRECATED_SCANF)
>> +# define FMT "%La %a"
>> +#else
>> +# define FMT "%La %as"
>> +#endif  
>
>That does simplify the patch nicely.  LGTM.

Thanks, this and the preceding patch are now committed.

References:
- [PATCH v3 00/11] Add IEEE long double <-> string functions for powerpc64le
  - From: Gabriel F. T. Gomes
- [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions
  - From: Gabriel F. T. Gomes
- Re: [PATCH v3 02/11] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions
  - From: Paul E Murphy

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]