This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Multiple locales: Add date_fmt (bug 24054)


On 31/12/19 10:31 pm, Rafal Luzynski wrote:
> The previous patch did not apply so here is the new version:
> 
> -------------------------------8<---------------------------------
> 
> From: =?UTF-8?q?Rafa=C5=82=20Lu=C5=BCy=C5=84ski?=
>  <digitalfreak@lingonborough.com>
> Date: Mon, 30 Dec 2019 11:58:18 +0100
> 
> It is not specified what should be the content of d_t_fmt and date_fmt
> but in the built-in C locale those fields have only one difference:
> date_fmt contains "%Z" (the current time zone) while d_t_fmt does not.
> 
> For most of the locales this commit does the following operation:
> copy d_t_fmt to date_fmt, and then remove "%Z" from d_t_fmt.
> If "%Z" was originally missing from d_t_fmt add it to date_fmt.
> It also corrects comments where necessary.
> 
> Exceptions:
> 
> * In bo_CN, dz_BT, and km_KH "%Z" has not been added to date_fmt because
>   it was too difficult.  In these locales date_fmt has been set to the
>   copy of d_t_fmt.
> * In en_DK "%Z" has not been removed from d_t_fmt in order to preserve
>   the conformance with the standard mentioned in the comment.
> 
> The command to identify and initially edit the locales that need the
> update was:
> 
>     for i in `grep -lw d_t_fmt *`
>     do
>         if ! grep -qw date_fmt $i ; then
>             awk '/d_t_fmt/ { print $0; gsub("d_t_fmt", "date_fmt"); } //{
> print $0 }' < $i > $i.next
>             mv $i.next $i
>         fi
>     done
> 
> and then each file was further edited manually.

This is OK to commit if you can do so before end of your day, Friday.

Thanks,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]