This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 14/16] linux: Enable vDSO clock_gettime64 for mips
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Thu, 2 Jan 2020 18:43:59 +0530
- Subject: Re: [PATCH 14/16] linux: Enable vDSO clock_gettime64 for mips
- References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> <20191217214728.2886-14-adhemerval.zanella@linaro.org>
On 18/12/19 3:17 am, Adhemerval Zanella wrote:
> It was added on Linux 5.4 (commit 1f66c45db3302).
> ---
> sysdeps/unix/sysv/linux/mips/sysdep.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/mips/sysdep.h b/sysdeps/unix/sysv/linux/mips/sysdep.h
> index c2bec03806..67a2f74df2 100644
> --- a/sysdeps/unix/sysv/linux/mips/sysdep.h
> +++ b/sysdeps/unix/sysv/linux/mips/sysdep.h
> @@ -16,11 +16,16 @@
> License along with the GNU C Library. If not, see
> <http://www.gnu.org/licenses/>. */
>
> +#include <sgidefs.h>
> +
Do you need this at all? It seems to me that the compiler sets _MIPS_SIM.
> #define VDSO_NAME "LINUX_2.6"
> #define VDSO_HASH 61765110
>
> /* List of system calls which are supported as vsyscalls. */
> #define HAVE_CLOCK_GETTIME_VSYSCALL "__vdso_clock_gettime"
> +#if _MIPS_SIM != _ABI64
> +#define HAVE_CLOCK_GETTIME64_VSYSCALL "__vdso_clock_gettime64"
> +#endif
> #define HAVE_GETTIMEOFDAY_VSYSCALL "__vdso_gettimeofday"
> #define HAVE_CLOCK_GETRES_VSYSCALL "__vdso_clock_getres"
>
>