This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH COMMITTED] MIPS: Fix circular definition of __LDBL_MANT_DIG__ in ieee754.h
- From: Zack Weinberg <zackw at panix dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 8 Jan 2020 14:39:13 -0500
- Subject: [PATCH COMMITTED] MIPS: Fix circular definition of __LDBL_MANT_DIG__ in ieee754.h
In commit aa706e13f4bfdf32a27c498902edf4f6006e433e,
sysdeps/mips/ieee754/ieee754.h was changed to use GCC’s predefined
macro __LDBL_MANT_DIG__, instead of including <float.h> and using
LDBL_MANT_DIG (and therefore polluting the user namespace with all of
the macros defined in float.h). In order to support compilers that
don’t provide __LDBL_MANT_DIG__, there is a fallback #if block which
was supposed to include <float.h> and then define __LDBL_MANT_DIG__ to
LDBL_MANT_DIG. However, at some point during the development of the
patch, a typo was introduced, causing the fallback block to define
__LDBL_MANT_DIG__ to expand to __LDBL_MANT_DIG__.
Correct this typo.
---
Since this is an obvious typo fix and time before the release is short,
I have already pushed this patch to master.
zw
---
sysdeps/mips/ieee754/ieee754.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/mips/ieee754/ieee754.h b/sysdeps/mips/ieee754/ieee754.h
index 75059f733b..62f17586f1 100644
--- a/sysdeps/mips/ieee754/ieee754.h
+++ b/sysdeps/mips/ieee754/ieee754.h
@@ -24,7 +24,7 @@
#ifndef __LDBL_MANT_DIG__
# include <float.h>
-# define __LDBL_MANT_DIG__ __LDBL_MANT_DIG__
+# define __LDBL_MANT_DIG__ LDBL_MANT_DIG
#endif
__BEGIN_DECLS
--
2.25.0.rc1