This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Drop dependency of dist target on ChangeLog


This looks good, except for the change to timezone/README:

+Please check the ChangeLog files in ChangeLog.old directory at the top level
+for the version of the tzcode and tzdata packages.

It's awkward to have to paw through ChangeLog.old for version numbers, plus when I took the trouble to actually do that I found that the version numbers there were incorrect. So I propose the attached patch instead.
>From 3c69ed681a2a2a290fabad120137d20d379a03dc Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 8 Jan 2020 17:48:49 -0800
Subject: [PATCH] Update timezone/README

* timezone/version: New file, also taken from tzcode2018i.
* timezone/README: Reword so that people needn't paw through
old ChangeLog files to see which version we're using, a process
that is error-prone.  Update an obsolescent URL.
---
 timezone/README  | 14 ++++++++------
 timezone/version |  1 +
 2 files changed, 9 insertions(+), 6 deletions(-)
 create mode 100644 timezone/version

diff --git a/timezone/README b/timezone/README
index fc50f1399f..da814e3bca 100644
--- a/timezone/README
+++ b/timezone/README
@@ -1,6 +1,7 @@
 The files
-	zic.c zdump.c tzfile.h private.h tzselect.ksh
+	zic.c zdump.c tzfile.h private.h tzselect.ksh version
 come from the tzcode package by Arthur David Olson et.al.
+The 'version' file specifies which tzcode version was used.
 
 The files
 	africa antarctica asia australasia europe
@@ -8,14 +9,15 @@ The files
 	backward systemv solar87 solar88 solar89
 	iso3166.tab zone.tab leapseconds yearistype
 come from the tzdata package by Arthur David Olson et.al.
-
-Please check the ChangeLog files in the top level directory for the
-version of the tzcode and tzdata packages.
+except that its 'yearistype.sh' file is renamed to 'yearistype'.
+These tzdata files were taken from tzdata 2009i and have not been
+updated since, as they do not affect a glibc installation and are
+present only for regression testing.
 
 Please also see: https://sourceware.org/glibc/wiki/SharedSourceFiles
 
-These packages may be found at ftp://ftp.iana.org/tz/releases/.  Commentary
-should be addressed to tz@iana.org.
+These packages may be found at https://ftp.iana.org/tz/releases/.
+Commentary should be addressed to tz@iana.org.
 
 The subdirectory testdata contains manually edited data files for
 regression testing purposes.
diff --git a/timezone/version b/timezone/version
new file mode 100644
index 0000000000..63f58006ee
--- /dev/null
+++ b/timezone/version
@@ -0,0 +1 @@
+2018i
-- 
2.24.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]