This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test

From: Stefan Liebler <stli at linux dot ibm dot com>
To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, libc-alpha at sourceware dot org
Date: Mon, 13 Jan 2020 11:08:59 +0100
Subject: Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test
References: <20191205172608.GA57577@aloka.lostca.se> <20191216143424.22882-1-ahajkova@redhat.com> <20200106180509.GA71028@aloka.lostca.se> <f14c8252-cfe2-d3a0-d808-10dba466a4bf@linaro.org> <56533d16-d7d1-4e79-5a8f-ed4accb17247@gotplt.org> <357df77f-f709-8b35-b28d-e64f4524f92a@linux.ibm.com> <4e54f470-f07d-558a-b52e-031fb5df1a9d@gotplt.org>

On 1/10/20 5:00 PM, Siddhesh Poyarekar wrote:

On 10/01/20 8:15 pm, Stefan Liebler wrote:

Hi,

If run on 32bit, this test fails while renaming tst-ldconfig-ld-mod.so
as there is no /usr/lib64 directory.

The attached patch is constructing the file name with help of
support_libdir_prefix.

If the patch is okay, let me know if I can commit it on master.


Nice catch, looks OK to me.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Committed.

Thanks,
Stefan

References:
- Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test
  - From: Arjun Shankar
- Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test
  - From: Adhemerval Zanella
- Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test
  - From: Siddhesh Poyarekar
- Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test
  - From: Stefan Liebler
- Re: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]