This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 2/3] elf: avoid redundant sort in dlopen
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: David Kilroy <David dot Kilroy at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Tue, 14 Jan 2020 16:41:57 -0300
- Subject: Re: [PATCH v3 2/3] elf: avoid redundant sort in dlopen
- References: <1575394197-18006-1-git-send-email-david.kilroy@arm.com> <1575394197-18006-3-git-send-email-david.kilroy@arm.com>
On 03/12/2019 14:30, David Kilroy wrote:
> l_initfini is already sorted by dependency in _dl_map_object_deps(),
> so avoid sorting again in dl_open_worker().
>
> Tested by running the testsuite on x86_64.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> elf/dl-open.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/elf/dl-open.c b/elf/dl-open.c
> index 9996fe9..c4d09c7c 100644
> --- a/elf/dl-open.c
> +++ b/elf/dl-open.c
> @@ -658,7 +658,6 @@ dl_open_worker (void *a)
> l = new->l_initfini[++j];
> }
> while (l != NULL);
> - _dl_sort_maps (maps, nmaps, NULL, false);
>
> int relocation_in_progress = 0;
>
>