This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Fix maybe-uninitialized error on powerpc
On 1/17/20 11:24 PM, Tulio Magno Quites Machado Filho wrote:
> Siddhesh Poyarekar <siddhesh@sourceware.org> writes:
>
>> On 18/01/20 3:34 am, Joseph Myers wrote:
>>> On Fri, 17 Jan 2020, Matheus Castanho wrote:
>>>
>>>> +
>>>> + /* t == 0 will never happen at this point, since 1/t can only be 0 if t is
>>>> + infinity, but before the division t == mantissa of x (exponent is 0). We
>>>> + can instruct the compiler to ignore this case. */
>>>> + if (t == 0)
>>>> + __builtin_unreachable();
>>>
>>> This needs a space before '()'.
>
> Fixed.
>
>>> OK with that change, but Siddhesh will need to confirm if it's OK to push
>>> at this development stage, and you'll need to say if you need someone to
>>> push it for you.
>>
>> This is fine.
>
> Pushed as 9f8b135f76ac7943d1e108b7f6e816f526b2208c.
>
> Thanks!
>
Thanks!