This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: patch with larger errors for "float"
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <codonell at redhat dot com>
- Cc: paul zimmermann <Paul dot Zimmermann at inria dot fr>, <libc-alpha at sourceware dot org>
- Date: Mon, 20 Jan 2020 23:46:11 +0000
- Subject: Re: patch with larger errors for "float"
- Ironport-sdr: amlJYVCQBTr4/T69C7EskGqfJa+rm5vmQRcdYutTgq1IFI4nAzbFNRZxBf2+TUdJYwrRzSg4m/ NVnEcxOd5R8ZngN5AeUbPqf4Iqtwe+jSeb7Ztb9024oBOAHuuDoUnVRrW+Q0gm+M2vCsWO+PiT XFPsSVhIJ5/34Kitd7bV0dNa9elCtaYWM5QOLEpVgCylnpff4RUczy3ZDZj0e1P3ETEqOyiDEE mMAowMROMOuoWGYB0g/+6vp/+vIhvZ/ZAgnEPfCDyyJj27Np2cDSm7rahdpH32XKFhpSu9gmap zcI=
- Ironport-sdr: efVUaJhHJWnQFSoEj8tz2y1cb+Zqu92oW5NFIaY4yACrTERi5Qlit/zRHiHDDqBhaW9HE5jWkm ug0xr8SPshWg==
- References: <mw4kwqmfye.fsf@tomate.loria.fr> <4ae44c35-8a10-c6fc-d95c-f485980bf440@redhat.com> <mwk15mhzd8.fsf@tomate.loria.fr> <b3a025a1-fba3-c164-4e88-d146db756a50@redhat.com>
On Mon, 20 Jan 2020, Carlos O'Donell wrote:
> (1) Does it make sense to add more input data points for the tests?
>
> What you are suggestion with your patch makes sense, and now your patch
> includes the input, output, and ULPs adjustment which makes it a complete
> patch that should pass the regression testing on x86_64.
FWIW, I previously added some test inputs based on random testing (but
random testing with many fewer inputs).
> (2) Are we changing all the things we need to change?
>
> Yes, you add inputs to 10 functions, and then add outputs to 10 function
> files for testing. That looks correct.
However, there are libm-test-ulps updates for only 6 functions (not for
atan2, cosh, erf or sin). Presuming the tests do indeed pass with those
updates for only 6 functions, maybe this indicates some difference in the
details of how glibc measures the error in a function versus how MPCHECK
does? (I think adding the extra tests for the other 4 functions is fine
even if they don't involve increased errors as measured by glibc.)
--
Joseph S. Myers
joseph@codesourcery.com