This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 10/10] C11 threads: Move implementation to sysdeps/pthread
On 21/01/2020 19:01, Samuel Thibault wrote:
>
>>> diff --git a/sysdeps/nptl/thrd_create.c b/sysdeps/nptl/thrd_create.c
>>> new file mode 100644
>>> index 0000000000..a9219db7bc
>>> --- /dev/null
>>> +++ b/sysdeps/nptl/thrd_create.c
>>> @@ -0,0 +1,2 @@
>>> +#define __pthread_create __pthread_create_2_1
>>> +#include "../pthread/thrd_create.c"
>>
>> I think it better to include fall path instead of relative one.
>
> Do you mean using #include_next ? That does not work, gcc warns that it's
> discouraged in primary source file.
I meant
#include <sysdeps/pthread/thrd_create.c>
I think it is clearly at source level to which file it refers and
require less change if the file is moved.