Re: [PATCH 6/6] linux: Use 32-bit time_t for rusage

[Lukasz Majewski <lukma at denx dot de>]

Hi Andreas,

> On Feb 04 2020, Lukasz Majewski wrote:
> 
> > I though that for ARM32 glibc wrappers for syscalls were generated
> > from sysdeps/unix/syscalls.list.  
> 
> But linux/generic/wordsize-32/fstatfs.c would override that, for
> example.

And this is IMHO the issue. Giving ARM32 full access to code located in
linux/generic/wordsize-32 is fragile as it will override wrappers
generated automatically.

In fact for ARM32 one would need either to locate the [sg]etitimer.c and
getrusage.c in e.g. sysdeps/unix/sysv/linux or allow compiling only
mentioned above files in linux/generic/wordsize-32.

The latter option would be possible with hack as:

introduce in sysdeps/unix/sysv/linux/arm/getitimer.c
#include <sysdeps/unix/sysv/linux/generic/wordsize-32/getitimer.c>


When following this idiom for setitimer and getrusage, the arm32 port
seems to compile with those files.

Is it the recommended way?

> 
> Andreas.
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgpme9ntALKFv.pgp
Description: OpenPGP digital signature