This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] Rewrite iconv option parsing [BZ #19519]
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Arjun Shankar <arjun dot is at lostca dot se>
- Cc: Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org, Siddhesh Poyarekar <siddhesh at gotplt dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Mon, 10 Feb 2020 21:28:50 +0100
- Subject: Re: [PATCH v4] Rewrite iconv option parsing [BZ #19519]
- References: <20200116155550.GA99449@aloka.lostca.se> <d99c6204-7161-035e-1c98-13e4f6467f13@redhat.com> <20200210195311.GA171@aloka.lostca.se>
On Feb 10 2020, Arjun Shankar wrote:
>> > +# Requires $twobyte input, $c flag, $from, and $to to be set; sets $ret
>> > +execute_test ()
>> > +{
>> > + PROG=`eval echo $ICONV`
>>
>> Why do you eval echo through a variable here?
>>
>> I expect this is due to your use of '' above, remove that and you should
>> be able to use $ICONV directly below.
>
> For the same reason, I've left this bit of code as-is in v5.
That should be
eval PROG=\"$ICONV\"
Putting echo as the only command inside $() is almost always wrong.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."