Re: [PATCH] Improve random memcpy benchmark

[Paul Clarke <pc at us dot ibm dot com>]

On 2/10/20 9:47 AM, Wilco Dijkstra wrote:
> Improve the random memcpy benchmark.  Double the number of copies and increase the
> memory sizes tested to 512KB. Add a more detailed distribution of memcpy alignment
> and sizes up to 4096 based on SPEC2017 traces.
> 
> --
> diff --git a/benchtests/bench-memcpy-random.c b/benchtests/bench-memcpy-random.c
> index d6a60a2eb014e3069b336b36d4b0797a3aa9bcce..c7b34ce3bfeb50ee611f176f6a8ccad42b216b88 100644
> --- a/benchtests/bench-memcpy-random.c
> +++ b/benchtests/bench-memcpy-random.c
> @@ -16,61 +16,85 @@
>     License along with the GNU C Library; if not, see
>     <https://www.gnu.org/licenses/>.  */
>  
> -#define MIN_PAGE_SIZE 131072
> +#define MIN_PAGE_SIZE (512*1024+4096)

Is the above expected to be a multiple of the system page size?

(Not all systems use 4096 byte pages or factors thereof).

PC