This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/15] powerpc: Use Linux kABI for syscall return

From: Florian Weimer <fw at deneb dot enyo dot de>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Tue, 11 Feb 2020 20:45:38 +0100
Subject: Re: [PATCH 02/15] powerpc: Use Linux kABI for syscall return
References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-2-adhemerval.zanella@linaro.org>

* Adhemerval Zanella:

> It changes the powerpc INTERNAL_VSYSCALL_CALL and INTERNAL_SYSCALL_NCS
> to return a negative value instead of returning the CR value on 'err'
> macro argument.

value on?  This part is unclear to me.

> The macro INTERNAL_SYSCALL_DECL is no longer required, and the
> INTERNAL_SYSCALL_ERROR_P follows the other Linux kABIS.

See my other comment about wording here.

The patch looks reasonable to me.

Follow-Ups:
- Re: [PATCH 02/15] powerpc: Use Linux kABI for syscall return
  - From: Adhemerval Zanella

References:
- [PATCH 01/15] powerpc: Consolidate Linux syscall definition
  - From: Adhemerval Zanella
- [PATCH 02/15] powerpc: Use Linux kABI for syscall return
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]