This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 11 Feb 2020 17:55:59 -0300
Subject: Re: [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL
References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-15-adhemerval.zanella@linaro.org> <87r1z1mgs6.fsf@oldenburg2.str.redhat.com>


On 11/02/2020 09:48, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> With all Linux ABIs using the expected Linux kABI to indicate
>> syscalls errors, the INTERNAL_SYSCALL_DECL is an empty declaration
>> on all ports.
>>
>> This patch removes the 'err' argument on INTERNAL_SYSCALL* macro
>> and remove the INTERNAL_SYSCALL_DECL usage.
> 
> I see some cases where you modify lines which contain INTERNAL_SYSCALL
> without changing it to INTERNAL_SYSCALL_CALL.  Maybe you can fix those
> as well?

Ack, I will update the patch.

> 
> Same for long vs long int.

Ack.

> 
> Apart from the other quirks I mentioned, this patch looks okay to me.
> 
> Thanks,
> Florian
>

References:
- [PATCH 01/15] powerpc: Consolidate Linux syscall definition
  - From: Adhemerval Zanella
- [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL
  - From: Adhemerval Zanella
- Re: [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]